From 1959badde721a07c4e51a8fa05d84602959780d9 Mon Sep 17 00:00:00 2001
From: Subhendu Kundu <subhendukundu@Subhendus-MacBook-Pro.local>
Date: Tue, 10 Mar 2026 20:01:08 +0530
Subject: [PATCH] =?UTF-8?q?fix:=20address=20review=20feedback=20=E2=80=94?=
 =?UTF-8?q?=20stale=20error=20message=20and=20*=20wildcard?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- assets.ts: change "Image exceeds" to "File exceeds" in size-limit error
- attachment-types.ts: handle plain "*" as allow-all wildcard pattern
- Add test for "*" wildcard (12 tests total)
---
 server/src/__tests__/attachment-types.test.ts | 8 ++++++++
 server/src/attachment-types.ts                | 1 +
 server/src/routes/assets.ts                   | 2 +-
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/server/src/__tests__/attachment-types.test.ts b/server/src/__tests__/attachment-types.test.ts
index af0a58b3..5a430102 100644
--- a/server/src/__tests__/attachment-types.test.ts
+++ b/server/src/__tests__/attachment-types.test.ts
@@ -86,4 +86,12 @@ describe("matchesContentType", () => {
     expect(matchesContentType("text/csv", patterns)).toBe(true);
     expect(matchesContentType("application/zip", patterns)).toBe(false);
   });
+
+  it("handles plain * as allow-all wildcard", () => {
+    const patterns = ["*"];
+    expect(matchesContentType("image/png", patterns)).toBe(true);
+    expect(matchesContentType("application/pdf", patterns)).toBe(true);
+    expect(matchesContentType("text/plain", patterns)).toBe(true);
+    expect(matchesContentType("application/zip", patterns)).toBe(true);
+  });
 });
diff --git a/server/src/attachment-types.ts b/server/src/attachment-types.ts
index 3f95156b..f9625de1 100644
--- a/server/src/attachment-types.ts
+++ b/server/src/attachment-types.ts
@@ -45,6 +45,7 @@ export function parseAllowedTypes(raw: string | undefined): string[] {
 export function matchesContentType(contentType: string, allowedPatterns: string[]): boolean {
   const ct = contentType.toLowerCase();
   return allowedPatterns.some((pattern) => {
+    if (pattern === "*") return true;
     if (pattern.endsWith("/*") || pattern.endsWith(".*")) {
       return ct.startsWith(pattern.slice(0, -1));
     }
diff --git a/server/src/routes/assets.ts b/server/src/routes/assets.ts
index ed8d5944..bd2f154d 100644
--- a/server/src/routes/assets.ts
+++ b/server/src/routes/assets.ts
@@ -33,7 +33,7 @@ export function assetRoutes(db: Db, storage: StorageService) {
     } catch (err) {
       if (err instanceof multer.MulterError) {
         if (err.code === "LIMIT_FILE_SIZE") {
-          res.status(422).json({ error: `Image exceeds ${MAX_ATTACHMENT_BYTES} bytes` });
+          res.status(422).json({ error: `File exceeds ${MAX_ATTACHMENT_BYTES} bytes` });
           return;
         }
         res.status(400).json({ error: err.message });