test: harden onboarding route coverage

tests/e2e/onboarding.spec.ts

@@ -22,14 +22,11 @@ const TASK_TITLE = "E2E test task";
 
 test.describe("Onboarding wizard", () => {
   test("completes full wizard flow", async ({ page }) => {
-    // Navigate to root — should auto-open onboarding when no companies exist
     await page.goto("/");
 
-    // If the wizard didn't auto-open (company already exists), click the button
     const wizardHeading = page.locator("h3", { hasText: "Name your company" });
     const newCompanyBtn = page.getByRole("button", { name: "New Company" });
 
-    // Wait for either the wizard or the start page
     await expect(
       wizardHeading.or(newCompanyBtn)
     ).toBeVisible({ timeout: 15_000 });
@@ -38,40 +35,28 @@ test.describe("Onboarding wizard", () => {
       await newCompanyBtn.click();
     }
 
-    // -----------------------------------------------------------
-    // Step 1: Name your company
-    // -----------------------------------------------------------
     await expect(wizardHeading).toBeVisible({ timeout: 5_000 });
-    await expect(page.locator("text=Step 1 of 4")).toBeVisible();
 
     const companyNameInput = page.locator('input[placeholder="Acme Corp"]');
     await companyNameInput.fill(COMPANY_NAME);
 
-    // Click Next
     const nextButton = page.getByRole("button", { name: "Next" });
     await nextButton.click();
 
-    // -----------------------------------------------------------
-    // Step 2: Create your first agent
-    // -----------------------------------------------------------
     await expect(
       page.locator("h3", { hasText: "Create your first agent" })
     ).toBeVisible({ timeout: 10_000 });
-    await expect(page.locator("text=Step 2 of 4")).toBeVisible();
 
-    // Agent name should default to "CEO"
     const agentNameInput = page.locator('input[placeholder="CEO"]');
     await expect(agentNameInput).toHaveValue(AGENT_NAME);
 
-    // Claude Code adapter should be selected by default
     await expect(
       page.locator("button", { hasText: "Claude Code" }).locator("..")
     ).toBeVisible();
 
-    // Select the "Process" adapter to avoid needing a real CLI tool installed
-    await page.locator("button", { hasText: "Process" }).click();
+    await page.getByRole("button", { name: "More Agent Adapter Types" }).click();
+    await page.getByRole("button", { name: "Process" }).click();
 
-    // Fill in process adapter fields
     const commandInput = page.locator('input[placeholder="e.g. node, python"]');
     await commandInput.fill("echo");
     const argsInput = page.locator(
@@ -79,52 +64,34 @@ test.describe("Onboarding wizard", () => {
     );
     await argsInput.fill("hello");
 
-    // Click Next (process adapter skips environment test)
     await page.getByRole("button", { name: "Next" }).click();
 
-    // -----------------------------------------------------------
-    // Step 3: Give it something to do
-    // -----------------------------------------------------------
     await expect(
       page.locator("h3", { hasText: "Give it something to do" })
     ).toBeVisible({ timeout: 10_000 });
-    await expect(page.locator("text=Step 3 of 4")).toBeVisible();
 
-    // Clear default title and set our test title
     const taskTitleInput = page.locator(
       'input[placeholder="e.g. Research competitor pricing"]'
     );
     await taskTitleInput.clear();
     await taskTitleInput.fill(TASK_TITLE);
 
-    // Click Next
     await page.getByRole("button", { name: "Next" }).click();
 
-    // -----------------------------------------------------------
-    // Step 4: Ready to launch
-    // -----------------------------------------------------------
     await expect(
       page.locator("h3", { hasText: "Ready to launch" })
     ).toBeVisible({ timeout: 10_000 });
-    await expect(page.locator("text=Step 4 of 4")).toBeVisible();
 
-    // Verify summary displays our created entities
     await expect(page.locator("text=" + COMPANY_NAME)).toBeVisible();
     await expect(page.locator("text=" + AGENT_NAME)).toBeVisible();
     await expect(page.locator("text=" + TASK_TITLE)).toBeVisible();
 
-    // Click "Open Issue"
-    await page.getByRole("button", { name: "Open Issue" }).click();
+    await page.getByRole("button", { name: "Create & Open Issue" }).click();
 
-    // Should navigate to the issue page
     await expect(page).toHaveURL(/\/issues\//, { timeout: 10_000 });
 
-    // -----------------------------------------------------------
-    // Verify via API that entities were created
-    // -----------------------------------------------------------
     const baseUrl = page.url().split("/").slice(0, 3).join("/");
 
-    // List companies and find ours
     const companiesRes = await page.request.get(`${baseUrl}/api/companies`);
     expect(companiesRes.ok()).toBe(true);
     const companies = await companiesRes.json();
@@ -133,7 +100,6 @@ test.describe("Onboarding wizard", () => {
     );
     expect(company).toBeTruthy();
 
-    // List agents for our company
     const agentsRes = await page.request.get(
       `${baseUrl}/api/companies/${company.id}/agents`
     );
@@ -146,7 +112,6 @@ test.describe("Onboarding wizard", () => {
     expect(ceoAgent.role).toBe("ceo");
     expect(ceoAgent.adapterType).toBe("process");
 
-    // List issues for our company
     const issuesRes = await page.request.get(
       `${baseUrl}/api/companies/${company.id}/issues`
     );
@@ -159,7 +124,6 @@ test.describe("Onboarding wizard", () => {
     expect(task.assigneeAgentId).toBe(ceoAgent.id);
 
     if (!SKIP_LLM) {
-      // LLM-dependent: wait for the heartbeat to transition the issue
       await expect(async () => {
         const res = await page.request.get(
           `${baseUrl}/api/issues/${task.id}`