feat(openclaw): add adapter hire-approved hooks
This commit is contained in:
180
server/src/__tests__/hire-hook.test.ts
Normal file
180
server/src/__tests__/hire-hook.test.ts
Normal file
@@ -0,0 +1,180 @@
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import type { Db } from "@paperclipai/db";
|
||||
import { notifyHireApproved } from "../services/hire-hook.js";
|
||||
|
||||
// Mock the registry so we control whether the adapter has onHireApproved and what it does.
|
||||
vi.mock("../adapters/registry.js", () => ({
|
||||
findServerAdapter: vi.fn(),
|
||||
}));
|
||||
|
||||
vi.mock("../services/activity-log.js", () => ({
|
||||
logActivity: vi.fn().mockResolvedValue(undefined),
|
||||
}));
|
||||
|
||||
const { findServerAdapter } = await import("../adapters/registry.js");
|
||||
const { logActivity } = await import("../services/activity-log.js");
|
||||
|
||||
function mockDbWithAgent(agent: { id: string; companyId: string; name: string; adapterType: string; adapterConfig?: Record<string, unknown> }): Db {
|
||||
return {
|
||||
select: () => ({
|
||||
from: () => ({
|
||||
where: () =>
|
||||
Promise.resolve([
|
||||
{
|
||||
id: agent.id,
|
||||
companyId: agent.companyId,
|
||||
name: agent.name,
|
||||
adapterType: agent.adapterType,
|
||||
adapterConfig: agent.adapterConfig ?? {},
|
||||
},
|
||||
]),
|
||||
}),
|
||||
}),
|
||||
} as unknown as Db;
|
||||
}
|
||||
|
||||
afterEach(() => {
|
||||
vi.clearAllMocks();
|
||||
});
|
||||
|
||||
describe("notifyHireApproved", () => {
|
||||
it("writes success activity when adapter hook returns ok", async () => {
|
||||
vi.mocked(findServerAdapter).mockReturnValue({
|
||||
type: "openclaw",
|
||||
onHireApproved: vi.fn().mockResolvedValue({ ok: true }),
|
||||
} as any);
|
||||
|
||||
const db = mockDbWithAgent({
|
||||
id: "a1",
|
||||
companyId: "c1",
|
||||
name: "OpenClaw Agent",
|
||||
adapterType: "openclaw",
|
||||
});
|
||||
|
||||
await expect(
|
||||
notifyHireApproved(db, {
|
||||
companyId: "c1",
|
||||
agentId: "a1",
|
||||
source: "approval",
|
||||
sourceId: "ap1",
|
||||
}),
|
||||
).resolves.toBeUndefined();
|
||||
|
||||
expect(logActivity).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({
|
||||
action: "hire_hook.succeeded",
|
||||
entityId: "a1",
|
||||
details: expect.objectContaining({ source: "approval", sourceId: "ap1", adapterType: "openclaw" }),
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it("does nothing when agent is not found", async () => {
|
||||
const db = {
|
||||
select: () => ({
|
||||
from: () => ({
|
||||
where: () => Promise.resolve([]),
|
||||
}),
|
||||
}),
|
||||
} as unknown as Db;
|
||||
|
||||
await expect(
|
||||
notifyHireApproved(db, {
|
||||
companyId: "c1",
|
||||
agentId: "a1",
|
||||
source: "join_request",
|
||||
sourceId: "jr1",
|
||||
}),
|
||||
).resolves.toBeUndefined();
|
||||
|
||||
expect(findServerAdapter).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("does nothing when adapter has no onHireApproved", async () => {
|
||||
vi.mocked(findServerAdapter).mockReturnValue({ type: "process" } as any);
|
||||
|
||||
const db = mockDbWithAgent({
|
||||
id: "a1",
|
||||
companyId: "c1",
|
||||
name: "Agent",
|
||||
adapterType: "process",
|
||||
});
|
||||
|
||||
await expect(
|
||||
notifyHireApproved(db, {
|
||||
companyId: "c1",
|
||||
agentId: "a1",
|
||||
source: "approval",
|
||||
sourceId: "ap1",
|
||||
}),
|
||||
).resolves.toBeUndefined();
|
||||
|
||||
expect(findServerAdapter).toHaveBeenCalledWith("process");
|
||||
expect(logActivity).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("logs failed result when adapter onHireApproved returns ok=false", async () => {
|
||||
vi.mocked(findServerAdapter).mockReturnValue({
|
||||
type: "openclaw",
|
||||
onHireApproved: vi.fn().mockResolvedValue({ ok: false, error: "HTTP 500", detail: { status: 500 } }),
|
||||
} as any);
|
||||
|
||||
const db = mockDbWithAgent({
|
||||
id: "a1",
|
||||
companyId: "c1",
|
||||
name: "OpenClaw Agent",
|
||||
adapterType: "openclaw",
|
||||
});
|
||||
|
||||
await expect(
|
||||
notifyHireApproved(db, {
|
||||
companyId: "c1",
|
||||
agentId: "a1",
|
||||
source: "join_request",
|
||||
sourceId: "jr1",
|
||||
}),
|
||||
).resolves.toBeUndefined();
|
||||
|
||||
expect(logActivity).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({
|
||||
action: "hire_hook.failed",
|
||||
entityId: "a1",
|
||||
details: expect.objectContaining({ source: "join_request", sourceId: "jr1", error: "HTTP 500" }),
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it("does not throw when adapter onHireApproved throws (non-fatal)", async () => {
|
||||
vi.mocked(findServerAdapter).mockReturnValue({
|
||||
type: "openclaw",
|
||||
onHireApproved: vi.fn().mockRejectedValue(new Error("Network error")),
|
||||
} as any);
|
||||
|
||||
const db = mockDbWithAgent({
|
||||
id: "a1",
|
||||
companyId: "c1",
|
||||
name: "OpenClaw Agent",
|
||||
adapterType: "openclaw",
|
||||
});
|
||||
|
||||
await expect(
|
||||
notifyHireApproved(db, {
|
||||
companyId: "c1",
|
||||
agentId: "a1",
|
||||
source: "join_request",
|
||||
sourceId: "jr1",
|
||||
}),
|
||||
).resolves.toBeUndefined();
|
||||
|
||||
expect(logActivity).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({
|
||||
action: "hire_hook.error",
|
||||
entityId: "a1",
|
||||
details: expect.objectContaining({ source: "join_request", sourceId: "jr1", error: "Network error" }),
|
||||
}),
|
||||
);
|
||||
});
|
||||
});
|
||||
@@ -1,5 +1,5 @@
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import { execute, testEnvironment } from "@paperclipai/adapter-openclaw/server";
|
||||
import { execute, testEnvironment, onHireApproved } from "@paperclipai/adapter-openclaw/server";
|
||||
import { parseOpenClawStdoutLine } from "@paperclipai/adapter-openclaw/ui";
|
||||
import type { AdapterExecutionContext } from "@paperclipai/adapter-utils";
|
||||
|
||||
@@ -419,3 +419,78 @@ describe("openclaw adapter environment checks", () => {
|
||||
expect(check?.level).toBe("error");
|
||||
});
|
||||
});
|
||||
|
||||
describe("onHireApproved", () => {
|
||||
it("returns ok when hireApprovedCallbackUrl is not set (no-op)", async () => {
|
||||
const result = await onHireApproved(
|
||||
{
|
||||
companyId: "c1",
|
||||
agentId: "a1",
|
||||
agentName: "Test Agent",
|
||||
adapterType: "openclaw",
|
||||
source: "join_request",
|
||||
sourceId: "jr1",
|
||||
approvedAt: "2026-03-06T00:00:00.000Z",
|
||||
message: "You're hired.",
|
||||
},
|
||||
{},
|
||||
);
|
||||
expect(result).toEqual({ ok: true });
|
||||
});
|
||||
|
||||
it("POSTs payload to hireApprovedCallbackUrl with correct headers and body", async () => {
|
||||
const fetchMock = vi.fn().mockResolvedValue(new Response(null, { status: 200 }));
|
||||
vi.stubGlobal("fetch", fetchMock);
|
||||
|
||||
const payload = {
|
||||
companyId: "c1",
|
||||
agentId: "a1",
|
||||
agentName: "OpenClaw Agent",
|
||||
adapterType: "openclaw",
|
||||
source: "approval" as const,
|
||||
sourceId: "ap1",
|
||||
approvedAt: "2026-03-06T12:00:00.000Z",
|
||||
message: "Tell your user that your hire was approved.",
|
||||
};
|
||||
|
||||
const result = await onHireApproved(payload, {
|
||||
hireApprovedCallbackUrl: "https://callback.example/hire-approved",
|
||||
hireApprovedCallbackAuthHeader: "Bearer secret",
|
||||
});
|
||||
|
||||
expect(result.ok).toBe(true);
|
||||
expect(fetchMock).toHaveBeenCalledTimes(1);
|
||||
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
|
||||
expect(url).toBe("https://callback.example/hire-approved");
|
||||
expect(init?.method).toBe("POST");
|
||||
expect((init?.headers as Record<string, string>)["content-type"]).toBe("application/json");
|
||||
expect((init?.headers as Record<string, string>)["Authorization"]).toBe("Bearer secret");
|
||||
const body = JSON.parse(init?.body as string);
|
||||
expect(body.event).toBe("hire_approved");
|
||||
expect(body.companyId).toBe(payload.companyId);
|
||||
expect(body.agentId).toBe(payload.agentId);
|
||||
expect(body.message).toBe(payload.message);
|
||||
});
|
||||
|
||||
it("returns failure when callback returns non-2xx", async () => {
|
||||
const fetchMock = vi.fn().mockResolvedValue(new Response("Server Error", { status: 500 }));
|
||||
vi.stubGlobal("fetch", fetchMock);
|
||||
|
||||
const result = await onHireApproved(
|
||||
{
|
||||
companyId: "c1",
|
||||
agentId: "a1",
|
||||
agentName: "A",
|
||||
adapterType: "openclaw",
|
||||
source: "join_request",
|
||||
sourceId: "jr1",
|
||||
approvedAt: new Date().toISOString(),
|
||||
message: "Hired",
|
||||
},
|
||||
{ hireApprovedCallbackUrl: "https://example.com/hook" },
|
||||
);
|
||||
|
||||
expect(result.ok).toBe(false);
|
||||
expect(result.error).toContain("500");
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user