fix: address greptile follow-up feedback

This commit is contained in:
dotta
2026-03-20 13:18:29 -05:00
parent 0f4a5716ea
commit 360a7fc17b
4 changed files with 15 additions and 6 deletions

View File

@@ -488,19 +488,26 @@ async function maybeAutoRestartChild() {
if (mode !== "dev" || restartInFlight || !child) return; if (mode !== "dev" || restartInFlight || !child) return;
if (dirtyPaths.size === 0 && pendingMigrations.length === 0) return; if (dirtyPaths.size === 0 && pendingMigrations.length === 0) return;
restartInFlight = true;
let health; let health;
try { try {
health = await getDevHealthPayload(); health = await getDevHealthPayload();
} catch { } catch {
restartInFlight = false;
return; return;
} }
const devServer = health?.devServer; const devServer = health?.devServer;
if (!devServer?.enabled || devServer.autoRestartEnabled !== true) return; if (!devServer?.enabled || devServer.autoRestartEnabled !== true) {
if ((devServer.activeRunCount ?? 0) > 0) return; restartInFlight = false;
return;
}
if ((devServer.activeRunCount ?? 0) > 0) {
restartInFlight = false;
return;
}
try { try {
restartInFlight = true;
await maybePreflightMigrations({ await maybePreflightMigrations({
autoApply: true, autoApply: true,
interactive: false, interactive: false,

View File

@@ -79,7 +79,7 @@ export function DevRestartBanner({ devServer }: { devServer?: DevServerHealthSta
) : ( ) : (
<div className="inline-flex items-center gap-2 rounded-full bg-amber-900/10 px-3 py-1.5 dark:bg-amber-100/10"> <div className="inline-flex items-center gap-2 rounded-full bg-amber-900/10 px-3 py-1.5 dark:bg-amber-100/10">
<RotateCcw className="h-3.5 w-3.5" /> <RotateCcw className="h-3.5 w-3.5" />
<span>Restart `pnpm dev:once` after the active work is safe to interrupt</span> <span>Restart <code>pnpm dev:once</code> after the active work is safe to interrupt</span>
</div> </div>
)} )}
</div> </div>

View File

@@ -76,7 +76,7 @@ export function InstanceExperimentalSettings() {
<section className="rounded-xl border border-border bg-card p-5"> <section className="rounded-xl border border-border bg-card p-5">
<div className="flex items-start justify-between gap-4"> <div className="flex items-start justify-between gap-4">
<div className="space-y-1.5"> <div className="space-y-1.5">
<h2 className="text-sm font-semibold">Enabled Isolated Workspaces</h2> <h2 className="text-sm font-semibold">Enable Isolated Workspaces</h2>
<p className="max-w-2xl text-sm text-muted-foreground"> <p className="max-w-2xl text-sm text-muted-foreground">
Show execution workspace controls in project configuration and allow isolated workspace behavior for new Show execution workspace controls in project configuration and allow isolated workspace behavior for new
and existing issue runs. and existing issue runs.

View File

@@ -74,7 +74,9 @@ export function InstanceGeneralSettings() {
<div className="space-y-1.5"> <div className="space-y-1.5">
<h2 className="text-sm font-semibold">Censor username in logs</h2> <h2 className="text-sm font-semibold">Censor username in logs</h2>
<p className="max-w-2xl text-sm text-muted-foreground"> <p className="max-w-2xl text-sm text-muted-foreground">
Hide the username segment in home-directory paths and similar log output. This is off by default. Hide the username segment in home-directory paths and similar operator-visible log output. Standalone
username mentions outside of paths are not yet masked in the live transcript view. This is off by
default.
</p> </p>
</div> </div>
<button <button