From 652fa8223e7bbcfe512248d32ff0e4b9bc18f089 Mon Sep 17 00:00:00 2001 From: Devin Foley Date: Fri, 20 Mar 2026 13:49:03 -0700 Subject: [PATCH] fix: invert reuseExistingServer and remove CI="" workaround MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The playwright.config.ts had `reuseExistingServer: !!process.env.CI` which meant CI would reuse (expect) an existing server while local dev would start one. This is backwards — in CI Playwright should manage the server, and in local dev you likely already have one running. Flip to `!process.env.CI` and remove the `CI: ""` env override from the workflow. Co-Authored-By: Claude Opus 4.6 --- .github/workflows/pr-e2e.yml | 1 - tests/e2e/playwright.config.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/pr-e2e.yml b/.github/workflows/pr-e2e.yml index f1616a47..599b3649 100644 --- a/.github/workflows/pr-e2e.yml +++ b/.github/workflows/pr-e2e.yml @@ -56,7 +56,6 @@ jobs: - name: Run e2e tests env: PAPERCLIP_E2E_SKIP_LLM: "true" - CI: "" run: pnpm run test:e2e - name: Upload Playwright report diff --git a/tests/e2e/playwright.config.ts b/tests/e2e/playwright.config.ts index fd7e8b59..33022502 100644 --- a/tests/e2e/playwright.config.ts +++ b/tests/e2e/playwright.config.ts @@ -25,7 +25,7 @@ export default defineConfig({ webServer: { command: `pnpm paperclipai run`, url: `${BASE_URL}/api/health`, - reuseExistingServer: !!process.env.CI, + reuseExistingServer: !process.env.CI, timeout: 120_000, stdout: "pipe", stderr: "pipe",