Add board mutation guard middleware
Require trusted browser origin (Origin or Referer header) for mutating requests from board actors, preventing cross-origin mutation attempts against the local-trusted API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
61
server/src/middleware/board-mutation-guard.ts
Normal file
61
server/src/middleware/board-mutation-guard.ts
Normal file
@@ -0,0 +1,61 @@
|
||||
import type { Request, RequestHandler } from "express";
|
||||
|
||||
const SAFE_METHODS = new Set(["GET", "HEAD", "OPTIONS"]);
|
||||
const DEFAULT_DEV_ORIGINS = [
|
||||
"http://localhost:5173",
|
||||
"http://127.0.0.1:5173",
|
||||
"http://localhost:3100",
|
||||
"http://127.0.0.1:3100",
|
||||
];
|
||||
|
||||
function parseOrigin(value: string | undefined) {
|
||||
if (!value) return null;
|
||||
try {
|
||||
const url = new URL(value);
|
||||
return `${url.protocol}//${url.host}`.toLowerCase();
|
||||
} catch {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
function trustedOriginsForRequest(req: Request) {
|
||||
const origins = new Set(DEFAULT_DEV_ORIGINS.map((value) => value.toLowerCase()));
|
||||
const host = req.header("host")?.trim();
|
||||
if (host) {
|
||||
origins.add(`http://${host}`.toLowerCase());
|
||||
origins.add(`https://${host}`.toLowerCase());
|
||||
}
|
||||
return origins;
|
||||
}
|
||||
|
||||
function isTrustedBoardMutationRequest(req: Request) {
|
||||
const allowedOrigins = trustedOriginsForRequest(req);
|
||||
const origin = parseOrigin(req.header("origin"));
|
||||
if (origin && allowedOrigins.has(origin)) return true;
|
||||
|
||||
const refererOrigin = parseOrigin(req.header("referer"));
|
||||
if (refererOrigin && allowedOrigins.has(refererOrigin)) return true;
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
export function boardMutationGuard(): RequestHandler {
|
||||
return (req, res, next) => {
|
||||
if (SAFE_METHODS.has(req.method.toUpperCase())) {
|
||||
next();
|
||||
return;
|
||||
}
|
||||
|
||||
if (req.actor.type !== "board") {
|
||||
next();
|
||||
return;
|
||||
}
|
||||
|
||||
if (!isTrustedBoardMutationRequest(req)) {
|
||||
res.status(403).json({ error: "Board mutation requires trusted browser origin" });
|
||||
return;
|
||||
}
|
||||
|
||||
next();
|
||||
};
|
||||
}
|
||||
Reference in New Issue
Block a user