From 88df0fecb071bb50adf38e41f83c37c93cb65a7c Mon Sep 17 00:00:00 2001 From: Devin Foley Date: Sun, 15 Mar 2026 19:39:12 -0700 Subject: [PATCH] fix: show validation error on incomplete login submit Address Greptile review feedback: - Show "Please fill in all required fields." instead of silently returning when form is submitted with missing fields - Remove pointer-events-none so keyboard users can reach the button and receive the same validation feedback Co-Authored-By: Paperclip --- ui/src/pages/Auth.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ui/src/pages/Auth.tsx b/ui/src/pages/Auth.tsx index b69f9a13..7f794a70 100644 --- a/ui/src/pages/Auth.tsx +++ b/ui/src/pages/Auth.tsx @@ -91,7 +91,11 @@ export function AuthPage() { className="mt-6 space-y-4" onSubmit={(event) => { event.preventDefault(); - if (!canSubmit || mutation.isPending) return; + if (mutation.isPending) return; + if (!canSubmit) { + setError("Please fill in all required fields."); + return; + } mutation.mutate(); }} > @@ -133,7 +137,7 @@ export function AuthPage() { type="submit" disabled={mutation.isPending} aria-disabled={!canSubmit || mutation.isPending} - className={`w-full ${!canSubmit ? "opacity-50 pointer-events-none" : ""}`} + className={`w-full ${!canSubmit && !mutation.isPending ? "opacity-50" : ""}`} > {mutation.isPending ? "Working…"