From 9184cf92ddd81822eb3be579d3e4a7fc40f70ee9 Mon Sep 17 00:00:00 2001 From: zvictor Date: Fri, 6 Mar 2026 11:28:31 -0300 Subject: [PATCH] fix: parseBooleanFromEnv silently treats common truthy values as false --- cli/src/commands/onboard.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cli/src/commands/onboard.ts b/cli/src/commands/onboard.ts index 9fee5f84..79353514 100644 --- a/cli/src/commands/onboard.ts +++ b/cli/src/commands/onboard.ts @@ -74,7 +74,10 @@ const ONBOARD_ENV_KEYS = [ function parseBooleanFromEnv(rawValue: string | undefined): boolean | null { if (rawValue === undefined) return null; - return rawValue === "true"; + const lower = rawValue.trim().toLowerCase(); + if (lower === "true" || lower === "1" || lower === "yes") return true; + if (lower === "false" || lower === "0" || lower === "no") return false; + return null; } function parseNumberFromEnv(rawValue: string | undefined): number | null {