aevgarik/paperclip
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix run detail live log polling when log ref is delayed

Browse Source
This commit is contained in:
Dotta
2026-03-06 13:24:20 -06:00
parent 0324259da3
commit c8bd578415
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
ui/src/pages/AgentDetail.tsx
View File

@@ -3,6 +3,7 @@ import { useParams, useNavigate, Link, useBeforeUnload } from "@/lib/router";
import { useQuery, useMutation, useQueryClient } from "@tanstack/react-query"; import { useQuery, useMutation, useQueryClient } from "@tanstack/react-query";
import { agentsApi, type AgentKey, type ClaudeLoginResult } from "../api/agents"; import { agentsApi, type AgentKey, type ClaudeLoginResult } from "../api/agents";
import { heartbeatsApi } from "../api/heartbeats"; import { heartbeatsApi } from "../api/heartbeats";
import { ApiError } from "../api/client";
import { ChartCard, RunActivityChart, PriorityChart, IssueStatusChart, SuccessRateChart } from "../components/ActivityCharts"; import { ChartCard, RunActivityChart, PriorityChart, IssueStatusChart, SuccessRateChart } from "../components/ActivityCharts";
import { activityApi } from "../api/activity"; import { activityApi } from "../api/activity";
import { issuesApi } from "../api/issues"; import { issuesApi } from "../api/issues";
@@ -1770,6 +1771,10 @@ function LogViewer({ run, adapterType }: { run: HeartbeatRun; adapterType: strin
}); });
const isLive = run.status === "running" || run.status === "queued"; const isLive = run.status === "running" || run.status === "queued";
function isRunLogUnavailable(err: unknown): boolean {
return err instanceof ApiError && err.status === 404;
}
function appendLogContent(content: string, finalize = false) { function appendLogContent(content: string, finalize = false) {
if (!content && !finalize) return; if (!content && !finalize) return;
const combined = `${pendingLogLineRef.current}${content}`; const combined = `${pendingLogLineRef.current}${content}`;
@@ -1904,7 +1909,7 @@ function LogViewer({ run, adapterType }: { run: HeartbeatRun; adapterType: strin
setLogOffset(0); setLogOffset(0);
setLogError(null); setLogError(null);
if (!run.logRef) { if (!run.logRef && !isLive) {
setLogLoading(false); setLogLoading(false);
return () => { return () => {
cancelled = true; cancelled = true;
@@ -1933,6 +1938,10 @@ function LogViewer({ run, adapterType }: { run: HeartbeatRun; adapterType: strin
} }
} catch (err) { } catch (err) {
if (!cancelled) { if (!cancelled) {
if (isLive && isRunLogUnavailable(err)) {
setLogLoading(false);
return;
}
setLogError(err instanceof Error ? err.message : "Failed to load run log"); setLogError(err instanceof Error ? err.message : "Failed to load run log");
} }
} finally { } finally {
@@ -1965,7 +1974,7 @@ function LogViewer({ run, adapterType }: { run: HeartbeatRun; adapterType: strin
// Poll shell log for running runs // Poll shell log for running runs
useEffect(() => { useEffect(() => {
if (!isLive || !run.logRef) return; if (!isLive) return;
const interval = setInterval(async () => { const interval = setInterval(async () => {
try { try {
const result = await heartbeatsApi.log(run.id, logOffset, 256_000); const result = await heartbeatsApi.log(run.id, logOffset, 256_000);
@@ -1977,12 +1986,13 @@ function LogViewer({ run, adapterType }: { run: HeartbeatRun; adapterType: strin
} else if (result.content.length > 0) { } else if (result.content.length > 0) {
setLogOffset((prev) => prev + result.content.length); setLogOffset((prev) => prev + result.content.length);
} }
} catch { } catch (err) {
if (isRunLogUnavailable(err)) return;
// ignore polling errors // ignore polling errors
} }
}, 2000); }, 2000);
return () => clearInterval(interval); return () => clearInterval(interval);
}, [run.id, run.logRef, isLive, logOffset]); }, [run.id, isLive, logOffset]);
const adapterInvokePayload = useMemo(() => { const adapterInvokePayload = useMemo(() => {
const evt = events.find((e) => e.eventType === "adapter.invoke"); const evt = events.find((e) => e.eventType === "adapter.invoke");